fix: remove password-length from credential logs and harden view definition parsing#1469
Open
tomaioo wants to merge 5 commits into
Open
Conversation
- Security: Sensitive Information Exposure in Credential Events - Security: SQL Query Construction Without Parameterization in QueryProcessor Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Sensitive Information Exposure in Credential Events - Security: SQL Query Construction Without Parameterization in QueryProcessor Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
The event is only consumed via __str__ for human-readable logs; no state is needed after removing password-length metadata.
sd-db
changed the title
Add unit tests for QueryProcessor empty view_definition handling and DescribeQueryProcessor malformed DESCRIBE EXTENDED rows.
sd-db
approved these changes
Jun 17, 2026
sd-db
left a comment
sd-db
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thx for the PR !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes: stop logging password-length metadata in
CredentialShardEvent, and make view-definition parsing more robust against empty or malformed DESCRIBE output.Changes
credential_events.py— stop logging password metadataCredentialShardEventpreviously logged password character count. That metadata can aid offline guessing even though the password itself is not logged. The event message is now a static"Sharding credentials"string with no password-related fields.Scope note:
CredentialLoadErrorandCredentialSaveErrorare unchanged in this PR. Redacting file paths in those error messages is a separate follow-up if needed.query.py— defensive view-definition parsingstartswith/endswithinstead of index access when stripping parentheses fromview_definition, avoidingIndexErroron empty strings."View Text"rows inDescribeQueryProcessorwith a clearerDbtRuntimeError.These are robustness improvements to metadata parsing, not SQL injection mitigation.